Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mime missing from bitstream model #18

Open
alanorth opened this issue Jun 10, 2024 · 1 comment
Open

mime missing from bitstream model #18

alanorth opened this issue Jun 10, 2024 · 1 comment
Assignees
@kshepherd
Labels
enhancement New feature or request

Comments

@alanorth
Copy link
Contributor

Currently the bitstream's mimetype is missing from the bitstream model. The client already passes the mimetype in create_bitstream(). If this was available in the model it could be used instead of checking whether the filename string contains ".pdf", for example.
@kshepherd kshepherd self-assigned this Jun 11, 2024
@kshepherd
Copy link
Collaborator

Ah yes, there is a HAL link from the bitstream entity for this: https://github.com/DSpace/RestContract/blob/main/bitstreams.md#format

The easiest way to handle this is to embed format in the response like .../bitstreams?embed=format -- and is part of a larger improvement needed, where we expect all sorts of object types in _embedded

kshepherd added a commit to kshepherd/dspace-rest-python that referenced this issue Jun 11, 2024
@kshepherd
the-library-code#18: Allow embed=[] in get_bitstreams and embed forma…
740e6d0 
…t in response

_embedded in HALResource
new BitstreamFormat model
get_bitstreams takes e.g. (embeds=['format'])
kshepherd added a commit to kshepherd/dspace-rest-python that referenced this issue Jun 11, 2024
@kshepherd
the-library-code#18: Allow embed=[] in get_bitstreams and embed forma…
27b9444 
…t in response

_embedded in HALResource
new BitstreamFormat model
get_bitstreams takes e.g. (embeds=['format'])
@kshepherd kshepherd mentioned this issue Jun 11, 2024
Merged
@kshepherd kshepherd added the enhancement New feature or request label Jun 11, 2024
kshepherd added a commit to kshepherd/dspace-rest-python that referenced this issue Nov 20, 2024
@kshepherd
the-library-code#18: Allow embed=[] in get_bitstreams and embed forma…
fbfbb1b 
…t in response

_embedded in HALResource
new BitstreamFormat model
get_bitstreams takes e.g. (embeds=['format'])
kshepherd added a commit that referenced this issue Dec 3, 2024
@kshepherd
Merge pull request #20 from kshepherd/bitstream_format_model
c888f2d 
#18: Allow embed=[] in methods and embed resources in response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kshepherd kshepherd

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alanorth @kshepherd