Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving text #26

Closed
emhoracek opened this issue Feb 15, 2016 · 1 comment
Closed

Improving text #26

emhoracek opened this issue Feb 15, 2016 · 1 comment

Comments

@emhoracek
Copy link
Contributor

@aepyornis added text, but as he noted in the code, the width seems buggy.

Multiplying number of characters by the font size doesn't work, because letter width varies considerably. In most fonts, "i" and "l" are much thinner than "w" or "m". So the word "mmmmm" is a lot longer than "lilli", even though those are both 5 letters. And I think the font-size in pixels is not quite the same as either width.

So, right now, placeImage works fine with text, but overlay looks really broken. :/

Not sure that right way to fix this, but it interfering with my solution to #19 so I'm going to try some things.

@emhoracek
Copy link
Contributor Author

Fixed by 6203a22 :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant