Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make code modular #32

Open
the-ethan-hunt opened this issue Dec 1, 2017 · 18 comments
Open

Make code modular #32

the-ethan-hunt opened this issue Dec 1, 2017 · 18 comments
Labels

Comments

@the-ethan-hunt
Copy link
Owner

This is a discussion to on how to make the code more modular and easy for debugging

@BrianMwangi21
Copy link
Contributor

Where do we start ?

@Yatish04
Copy link
Contributor

Yatish04 commented Dec 1, 2017

I was thinking about modularising each functionality that we are going to add.

@BrianMwangi21
Copy link
Contributor

I'm not too familiar with modularising. Any tutorials I can quickly use to catch up ? Or can you explain in simple step forms ?

PS: Just asking, is it how the 'play jole' function is performed in another file in the modules folder or ?

I appreciate.

@Yatish04
Copy link
Contributor

Yatish04 commented Dec 1, 2017

Convert the big code into small python files with each of them being able to execute the functions it is supposed to be so that we can import those in the main program and use it along with GUI.

@BrianMwangi21
Copy link
Contributor

Can you point me to examples ?

@the-ethan-hunt
Copy link
Owner Author

But this needs to be done with both the versions.

@BrianMwangi21
Copy link
Contributor

You mean the Windows and Linux versions ?

@the-ethan-hunt
Copy link
Owner Author

Yes, of course. Before we modulate the code, I suggest we remove the issues plaguing it like Youtube not working on Linux and absence of B.E.N.J.I. for MacOS. Just an opinion. 😅

@BrianMwangi21
Copy link
Contributor

Everything else is okay but those two issues ?

@the-ethan-hunt
Copy link
Owner Author

Just an opinion. I would like to know what you all think and then we can proceed. Open-source is a democracy after all 😄

@BrianMwangi21
Copy link
Contributor

I second you. Once B.E.N.J.I. works on all platforms, we now build up on it

@kaushal-py
Copy link
Contributor

.
├── demos
│   ├── working-linux.gif
│   └── working-windows.gif
├── features
│   ├── google.py
│   ├── __init__.py
│   ├── news.py
│   └── youtube.py
├── functions
│   ├── __init__.py
│   ├── speak.py
│   └── speechtoText.py
├── gui
│   ├── home.py
│   ├── __init__.py
│   ├── splashscreen.py
│   └── static
│       ├── button.png
│       └── logo.ico
└── main.py

As suggested by @Yatish04 too, we could have the following structure for our code. @the-ethan-hunt yes, we should fix other issues first, and then make a switch. Maybe we could also realise a better structure for our code by then. :-)

@Yatish04
Copy link
Contributor

Yatish04 commented Dec 2, 2017

This is fine I suppose @kb-studios

@the-ethan-hunt
Copy link
Owner Author

Then I think we should solve the other issues and then focus on making it modular. I liked what @kb-studios has done. We could later go by that

@sara-02
Copy link

sara-02 commented Jul 18, 2018

@the-ethan-hunt Since this issue is still valid, I would rather emove the KWoC tag from it.

@HemabhKamboj
Copy link

@the-ethan-hunt, I am working under GSSoC 19. Can I start working with this issue, if its ok as of now? Also, I will first breakdown Linux version, then go for windows.

@srishilesh
Copy link
Contributor

@the-ethan-hunt I'll go for working out this issue in Windows.

@srishilesh
Copy link
Contributor

@the-ethan-hunt I'll go for working out this issue in Windows.

Please add GSSoC 19 label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants