Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen on Android #23

Open
Robert27 opened this issue Aug 11, 2024 · 2 comments
Open

Fullscreen on Android #23

Robert27 opened this issue Aug 11, 2024 · 2 comments

Comments

@Robert27
Copy link

iOS uses FullWindowOverlay to achieve a fullscreen modal.
Is something like this also possible on Android?

@janicduplessis
Copy link
Member

In general on android it shouldn’t be needed. On iOS it allows to render on top of screens that have a modal presentation, otherwise it will display under the modal screen and won’t be visible. Is there a case on android where this is a problem?

@Robert27
Copy link
Author

I use the BottomSheet within BottomTabs with Expo Router. On iOS, the sheet covers the BottomBar, on Android the sheet only starts above the BottomBar.

I have already experimented, if you remove the ModalProvider here and instead place one in the root stack of the app, then the bottom sheet also covers the bottom bar on Android.

<BottomSheetModalProvider>

Therefore, I would suggest an option with which you can deactivate the internal provider, by just returning a react fragment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants