Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with new 0.2.4 version and centralized views not running to the bottom of the sheet #18

Open
emilstepanian opened this issue Jul 3, 2023 · 1 comment

Comments

@emilstepanian
Copy link

emilstepanian commented Jul 3, 2023

Hi,

I am using this library for two types of navigation views. One is a bottom sheet and another is what I call a "floating window", which are these views that pop up from the bottom:

My implementation is that I just have a snapPoint that is 100% and then I centralize a small view in the middle of the transparent modal.

With the new 0.2.4 update, I am suddenly unable to centralize these windows in the middle of the screen. All of my views are sticky to the top, regardless of what styles I try to change. I can of course reduce the snap point, but that doesn't work dynamically.

I can see that the update includes the dynamic snap points (content), but I guess that's assuming the content run to the bottom of the screen, hence why its know working for me.

I can see a fix for me is to set contentHeight on the component to undefined in BottomSheetView.tsx.

I understand that my implementation is not really using your library as a "bottom sheet", so I understand if its not something you feel like taking into consideration. But it would be nice to be able to enable/disable it, since this minor update have had a major impact on my app 😄

@emilstepanian
Copy link
Author

emilstepanian commented Jul 3, 2023

Actually its been ruining all my bottom sheets, also the navigations I've been using as true bottom sheets:

With contentHeight undefined and expected results:

With contentHeight set to animatedContentHeight:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant