forked from Azure/azure-rest-api-specs
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE][Internal testing] - Test 9/29/2023 / 5 - Test LintDiff fix to RPC codes #3044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to mergeNext steps that must be taken to merge this PR:
|
Swagger Generation Artifacts
|
Generated ApiView
|
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
agfood.json | 2020-05-12-preview(9c78126) | 2020-05-12-preview(main) |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) | new version | base version |
---|---|---|
package-2020-05-12-preview | package-2020-05-12-preview(9c78126) | package-2020-05-12-preview(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
ResourceNameRestriction |
The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L9 |
ParametersOrder |
The parameters:extensionId,farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L10 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L10 |
ParametersOrder |
The parameters:extensionId,farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L56 |
ParametersOrder |
The parameters:extensionId,farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L102 |
ParametersOrder |
The parameters:extensionId,farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L148 |
ResourceNameRestriction |
The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L195 |
ResourceNameRestriction |
The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L466 |
ParametersOrder |
The parameters:farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L510 |
ParametersOrder |
The parameters:farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L571 |
UnSupportedPatchProperties |
Mark the top-level property 'location', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. These properties are not patchable. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L596 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L921 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L948 |
TopLevelResourcesListBySubscription |
The top-level resource 'FarmBeatsExtension' does not have list by subscription operation, please add it. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L1093 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L1097 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L1119 |
ProvisioningStateValidation |
ProvisioningState must have terminal states: Succeeded, Failed and Canceled. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L1167 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L1186 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L1219 |
PropertiesTypeObjectNoDefinition |
Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L1236 |
The API version:2020-05-12-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L6 |
|
Use the latest version v5 of types.json. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L27 |
|
Use the latest version v5 of types.json. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L30 |
|
Use the latest version v5 of types.json. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L33 |
|
Use the latest version v5 of types.json. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L46 |
|
Use the latest version v5 of types.json. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L73 |
|
Use the latest version v5 of types.json. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L76 |
|
Use the latest version v5 of types.json. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L79 |
|
Use the latest version v5 of types.json. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L92 |
|
Use the latest version v5 of types.json. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L119 |
️️✔️
~[NotRequired_Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
~[NotRequired_Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
~[NotRequired_Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
PR Summary succeeded [Detail] [Expand]
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
This was referenced Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSIA