Jack tn/test convert prettier #3024

JackTn · 2023-09-18T15:44:59Z

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

- Move Prettier check from unified pipeline to own devops pipeline - Refactor scripts and yml templates for sharing with TS Validation

Update widgets.json

…sting Update widgets.json

…st-1 Update widgets.json

Testing assistant

…sistant Testing with spec change

…/testConvertPrettier

openapi-pipeline-app-test · 2023-09-18T15:45:03Z

Next Steps to merge

Next steps that must be taken to merge this PR:

❌ Your PR is in purview of ARM review (label: ARMReview). Please ensure your PR is on the ARM PR review queue - see instructions in steps 1 and 2 in the PR description diagram.
❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it. In addition, refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app-test · 2023-09-18T15:45:04Z

Swagger Generation Artifacts

️️✔️~[NotRequired_Staging] ApiDocPreview succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app-test · 2023-09-18T15:45:05Z

Swagger pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

openapi-pipeline-app-test · 2023-09-18T15:45:06Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️️✔️~[NotRequired_Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️~[NotRequired_Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️~[NotRequired_Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️PR Summary succeeded [Detail] [Expand]

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

JackTn · 2023-09-19T08:27:51Z

/azp run

azure-pipelines · 2023-09-19T08:27:57Z

No pipelines are associated with this pull request.

JackTn · 2023-09-26T07:28:17Z

/azp run

azure-pipelines · 2023-09-26T07:28:23Z

No pipelines are associated with this pull request.

JackTn · 2023-10-09T06:25:47Z

/azp run

azure-pipelines · 2023-10-09T06:25:52Z

Pull request contains merge conflicts.

JackTn · 2023-10-09T06:30:30Z

/azp run

azure-pipelines · 2023-10-09T06:30:35Z

Pull request contains merge conflicts.

JackTn · 2023-10-09T06:33:20Z

/azp run

azure-pipelines · 2023-10-09T06:33:26Z

Pull request contains merge conflicts.

JackTn · 2023-10-09T06:37:00Z

/azp run

azure-pipelines · 2023-10-09T06:37:06Z

Pull request contains merge conflicts.

JackTn · 2023-10-09T06:51:55Z

123

JackTn · 2023-10-09T06:54:09Z

123

JackTn · 2023-10-09T06:59:12Z

123

JackTn · 2023-10-09T07:21:09Z

/azp run

azure-pipelines · 2023-10-09T07:21:15Z

Pull request contains merge conflicts.

JackTn · 2023-10-09T07:25:34Z

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask [email protected] (or NullMDR in github) for additional help.

JackTn · 2023-10-09T08:15:49Z

/azp run

azure-pipelines · 2023-10-09T08:15:55Z

No pipelines are associated with this pull request.

JackTn · 2023-10-10T08:19:07Z

/azp run

azure-pipelines · 2023-10-10T08:19:14Z

No pipelines are associated with this pull request.

weshaggard and others added 16 commits September 8, 2023 14:47

Add Prettier as its own pipeline check

71ec626

- Move Prettier check from unified pipeline to own devops pipeline - Refactor scripts and yml templates for sharing with TS Validation

PR feedback

c1633ae

Keep Swagger PrettierCheck name for now

98600a2

Update widgets.json

dd60999

Merge pull request #3017 from test-repo-billy/user/raych1/typespec-test

a4f05e9

Update widgets.json

Update widgets.json

4d5a926

Merge pull request #3018 from test-repo-billy/user/raych1/typespec-test1

68272cf

Update widgets.json

Update widgets.json

a6a8dd4

Merge pull request #3020 from test-repo-billy/user/raych1/typespec-te…

78ab4d0

…sting Update widgets.json

Update widgets.json

a1fc01f

Merge pull request #3021 from test-repo-billy/user/raych1/typespec-te…

5c544ab

…st-1 Update widgets.json

Testing assistant

1fe48fa

Merge pull request #3022 from test-repo-billy/user/raych1/test-assistant

23ede72

Testing assistant

Update widgets.json

c3a4421

Merge pull request #3023 from test-repo-billy/user/raych1/test-sdk-as…

7df9bd5

…sistant Testing with spec change

Merge remote-tracking branch 'weshaggard/ConvertPrettier' into jackTn…

a4bd4e4

…/testConvertPrettier

JackTn requested review from weshaggard, mikeharder, konrad-jamrozik and tadelesh as code owners September 18, 2023 15:44

JackTn removed request for tadelesh, konrad-jamrozik, weshaggard and mikeharder September 18, 2023 15:45

azure-sdk mentioned this pull request Sep 18, 2023

[AutoPR sdk/resourcemanager/netapp/armnetapp] Jack tn/test convert prettier azure-sdk/azure-sdk-for-go#7310

Closed

openapi-pipeline-app-test bot added the CI-BreakingChange-Go label Sep 18, 2023

AzureRestAPISpecReview added CI-MissingBaseCommit new-api-version resource-manager labels Sep 19, 2023

Merge branch 'Azure:main' into main

80ebd30

Merge branch 'main' into jackTn/testConvertPrettier

32279df

AzureRestAPISpecReview removed the BreakingChangeReviewRequired label Oct 9, 2023

konrad-jamrozik force-pushed the main branch from 6f9f31c to d8e7a99 Compare February 22, 2024 23:02

konrad-jamrozik closed this Feb 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jack tn/test convert prettier #3024

Jack tn/test convert prettier #3024

JackTn commented Sep 18, 2023 •

edited by workflow-bot-test bot

Loading

openapi-pipeline-app-test bot commented Sep 18, 2023 •

edited

Loading

openapi-pipeline-app-test bot commented Sep 18, 2023 •

edited

Loading

openapi-pipeline-app-test bot commented Sep 18, 2023 •

edited

Loading

openapi-pipeline-app-test bot commented Sep 18, 2023 •

edited

Loading

JackTn commented Sep 19, 2023

azure-pipelines bot commented Sep 19, 2023

JackTn commented Sep 26, 2023

azure-pipelines bot commented Sep 26, 2023

JackTn commented Oct 9, 2023

azure-pipelines bot commented Oct 9, 2023

JackTn commented Oct 9, 2023

azure-pipelines bot commented Oct 9, 2023

JackTn commented Oct 9, 2023

azure-pipelines bot commented Oct 9, 2023

JackTn commented Oct 9, 2023

azure-pipelines bot commented Oct 9, 2023

JackTn commented Oct 9, 2023

JackTn commented Oct 9, 2023

JackTn commented Oct 9, 2023

JackTn commented Oct 9, 2023

azure-pipelines bot commented Oct 9, 2023

JackTn commented Oct 9, 2023

JackTn commented Oct 9, 2023

azure-pipelines bot commented Oct 9, 2023

JackTn commented Oct 10, 2023

azure-pipelines bot commented Oct 10, 2023

Jack tn/test convert prettier #3024

Jack tn/test convert prettier #3024

Conversation

JackTn commented Sep 18, 2023 • edited by workflow-bot-test bot Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Viewing API changes

Suppressing failures

Getting help

openapi-pipeline-app-test bot commented Sep 18, 2023 • edited Loading

Next Steps to merge

openapi-pipeline-app-test bot commented Sep 18, 2023 • edited Loading

Swagger Generation Artifacts

openapi-pipeline-app-test bot commented Sep 18, 2023 • edited Loading

openapi-pipeline-app-test bot commented Sep 18, 2023 • edited Loading

Swagger Validation Report

JackTn commented Sep 19, 2023

azure-pipelines bot commented Sep 19, 2023

JackTn commented Sep 26, 2023

azure-pipelines bot commented Sep 26, 2023

JackTn commented Oct 9, 2023

azure-pipelines bot commented Oct 9, 2023

JackTn commented Oct 9, 2023

azure-pipelines bot commented Oct 9, 2023

JackTn commented Oct 9, 2023

azure-pipelines bot commented Oct 9, 2023

JackTn commented Oct 9, 2023

azure-pipelines bot commented Oct 9, 2023

JackTn commented Oct 9, 2023

JackTn commented Oct 9, 2023

JackTn commented Oct 9, 2023

JackTn commented Oct 9, 2023

azure-pipelines bot commented Oct 9, 2023

JackTn commented Oct 9, 2023

JackTn commented Oct 9, 2023

azure-pipelines bot commented Oct 9, 2023

JackTn commented Oct 10, 2023

azure-pipelines bot commented Oct 10, 2023

JackTn commented Sep 18, 2023 •

edited by workflow-bot-test bot

Loading

openapi-pipeline-app-test bot commented Sep 18, 2023 •

edited

Loading

openapi-pipeline-app-test bot commented Sep 18, 2023 •

edited

Loading

openapi-pipeline-app-test bot commented Sep 18, 2023 •

edited

Loading

openapi-pipeline-app-test bot commented Sep 18, 2023 •

edited

Loading