Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[t-server] Stabilize logiclayer properties param parsing behavior #310

Open
frabarz opened this issue Mar 17, 2021 · 0 comments
Open

[t-server] Stabilize logiclayer properties param parsing behavior #310

frabarz opened this issue Mar 17, 2021 · 0 comments

Comments

@frabarz
Copy link
Contributor

frabarz commented Mar 17, 2021

The logiclayer endpoint parsing happens with this logic. Specifically, the properties parsing happens in this fragment.

Note the comment: the code currently checks in a for loop if the property's name is present in the cache HashMap, and breaks the loop if it isn't. This means passing &properties=valid,valid,invalid,valid as parameter in the query would return only the first two valid properties, and ignore the last one silently. This is not a good behavior, because the user expects 4 properties, and is not getting informed why only gets 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant