adds healthcheck endpoint #308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds ping method to backend on clickhouse and mysql, pg is still on hold updates test case
hwchen
approved these changes
Feb 27, 2021
There was a problem hiding this comment.
Looks good. Just trying to think if there's another way to do timeouts besides pulling tokio in. Perhaps it doesn't really matter, since timeout handling will need to be changed with the updating of dependencies anyways (tokio moved to a somewhat different strategy for exposing timeout API)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
/healthcheckendpoint to the tesseract-server crate, and the needed logic for it to work. This includes access to a ping function for backends. The implementation is done for clickhouse and mysql, postgres is still on hold because the way is implemented is a bit confusing for me.This PR also includes a check in the e2e test case.
Closes #307