Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/Feature request: Scaling mode doesn't change #295

Open
woon0 opened this issue Feb 22, 2024 · 4 comments
Open

Bug/Feature request: Scaling mode doesn't change #295

woon0 opened this issue Feb 22, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@woon0
Copy link

woon0 commented Feb 22, 2024

I use a 21:9 Ultrawide. I want to be able to switch between [16:9 stretched to 21:9] and [16:9 on 21:9 with black bars] for use in different games (stretched on CS, black bars on Fortnite). I do this in NVIDIA Control Panel by switching "Scaling mode" between "Fullscreen" and "No scaling"/"Aspect Ratio". This scaling setting however does not save in DisplayMagician, if I have "Fullscreeen" selected in NVIDIA Control Panel and try switching to a profile where "Aspect Ratio" was picked, the resolution is still stretched as if I had "Fullscreen" selected (which the now applied profile shouldn't). If DisplayMagician had this feature, it would save me the effort of having to switch in (the surprisingly slow) NVIDIA Control Panel every time.

I would like the scaling setting to be stored in the profile file.

I have considered and tried other software, but they have their own negative quirks, and soDisplayMagician is the best software I've found.

I know it is possible to save this setting in a profile file, Helios Display Management is able to (however I can't stand the seemingly unchangable 30 second time countdown every time a profile should switch).

@woon0 woon0 added the enhancement New feature or request label Feb 22, 2024
@terrymacdonald
Copy link
Owner

terrymacdonald commented Feb 22, 2024 via email

@woon0
Copy link
Author

woon0 commented Feb 22, 2024

I understand. I mainly reported this to bring it to your attention, and to hope that it fit into a future addition.

I can continue to look for a replacement, or just use Helios despite the 30s wait.

Thank you.

@terrymacdonald
Copy link
Owner

@woon0 I had a closer look at your issue, and this feature should already be supported in v2.5.0 of DisplayMagician. Though with that said I've just realised that there is a bug in v2.5.0 where it doesnt always apply the NvAPI_SetDisplayConfig configuration every time due to a bug in my library (due to the way that C# handles interfacing with the C++ NVIDIA NvAPI DLL).

Basically you'll be a bit stuck for the next little while as I'm going to need to slightly rewrite NVIDIALibrary to use classes rather than structs for how it interacts with the NVIDIA driver, so I might need to look at how Soroush Falahati handles it in his NvAPIWrapper.net codebase. Le sigh.

I've also just realised this is a critical bug that will stop me releasing the upcoming DM v2.6.0. I hadn't realised that SetDisplayConfig was involved in handling the NVIDIA scaling, and to avoid this error I've simply disabled that code in v.2.6.0. This isn't going to work, as many people use the NVIDIA specific controls, and that is going to cause some issues.

Damn.

Looks like I've got a lot of code writing in my future, and looks like I will have to delay the release of DM v2.6.0 for another month or two :(.

Thanks
Terry

@terrymacdonald terrymacdonald added this to the 2.6.0 milestone Mar 3, 2024
@terrymacdonald
Copy link
Owner

Hi All,

Time for an update.

The fix is in the code and works (also we now support 3rd apps and games added to Steam library too!) but my current hold up is actually in the packaging of the application into a windows installer. I've been testing different ways to do this as the move from .net framework 4.8.1 to .net core 8.0.0 has been a massive change. It has resulted in a completely different set of binaries and dlls and other files being created, as well as a different build process too. This is all taking some time to figure out.

I've gone from a WIXv3 based installer to a windows default installer to an NSIS installer then back to a WIXv4 installer all within the last month. It's necessitated me building a brand new way of handling the desktop background context menu, and even down to which libraries are used within the application. It's been a ton of work.

I'm now down to the last few bugs to iron out, and to finish the new packaging process. I think I should have something ready for everyone to test within the next month (assuming there aren't anymore show stoppers.

My goal is to then send out messages through this issues list to get you all to test some DM v2.6.0 test builds, and then once the major bugs are ironed out I will push out the DM v2.6.0 beta to those users who opted in the beta builds. And then I'll finally push the DM v2.6.0 update to the main user group.

Lastly, I've decided to hold back the NVIDIALibrary update for now until DM v2.7.0 as it requires a LOT more work testing and troubleshooting many errors. The Steam beta client changing file structures has forced my hand here a little bit, so a better NVIDIALibrary will just have to wait for now.

Thanks
Terry

@terrymacdonald terrymacdonald modified the milestones: 2.7.1, 2.8.0 Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants