-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Terrarium - Providers]: Implementation of Storage Feature - 1 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjanikshree12
requested review from
ilijad1,
dkPranav,
odelanno,
adcharre and
vmilovanovicc
April 25, 2024 15:55
odelanno
requested changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gen_proto.sh needs to be upgraded to include the storage protocol buffer file so that everything is re generated correctly.
odelanno
previously approved these changes
Apr 26, 2024
adcharre
reviewed
Apr 26, 2024
adcharre
previously approved these changes
Apr 29, 2024
* implementation of consumer service * update in functions as we remove consumer service * go fmt * Update internal/provider/services/storage/storage.go Co-authored-by: Adam Charrett <[email protected]> * updated storage.go * enhance error logs * updated storage_test * fix * fix * updated storage_test and mock server * [Terrarium - Providers]: Implementation of Storage Feature - 3 (#72) --------- Co-authored-by: Anjani Kumar Srivastava <[email protected]> Co-authored-by: Adam Charrett <[email protected]>
adcharre
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
Protobuff definitions for storage service having functionalities such as download provider binary, shasum and signature files which is a required metadata that a particular version and platform of a provider requires.
gRPC code generated by protoc compiler tool from the protobuff definitions.
Description:
S3 Directory tree structure to be followed.
Note: Shasum file and signature is common for each version, so getting stored at version level.