Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skipped tokens should be part of the syntax tree #143

Open
terrajobst opened this issue May 13, 2020 · 0 comments · May be fixed by #176
Open

Skipped tokens should be part of the syntax tree #143

terrajobst opened this issue May 13, 2020 · 0 comments · May be fixed by #176
Labels
bug Something isn't working episode

Comments

@terrajobst
Copy link
Owner

When the parser decides to skip tokens we should make sure that the tokens are still recorded in the syntax tree. Otherwise syntax highlight won't work.
@terrajobst terrajobst added bug Something isn't working episode labels May 13, 2020
Catalin-Andronie added a commit to Catalin-Andronie/minsk that referenced this issue Jul 6, 2021
@Catalin-Andronie
Record skipped tokens as leading trivia on the fabricated token
eae14f9 
Fixes terrajobst#143
@Catalin-Andronie Catalin-Andronie linked a pull request Jul 6, 2021 that will close this issue
Open
Catalin-Andronie added a commit to Catalin-Andronie/minsk that referenced this issue Jul 20, 2021
@Catalin-Andronie
Record skipped tokens as leading trivia on the fabricated token
50a5ac2 
Fixes terrajobst#143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working episode
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Record skipped tokens as leading trivia on the fabricated token Catalin-Andronie/minsk
1 participant
@terrajobst