-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: refine PR tests to exclude unchanged complex examples #778
Comments
Example remaining folders: looker/ et al contains test.yaml files, so samples are validated but not executed (slight increase to CI exec time) |
@apeabody confirming your intent on 669, this comment was added to the code:
Do you intend to always test samples with |
Hey @glasnt! I'd have to refresh my memory, but the intention was to avoid deleting non-TF test artifacts that are (commonly) in sub-directories below the TF code itself. Likely the logic can/should be improved. :) At the very least it should be safe to delete folders with |
There may be a new general solution on this coming from my team, but in the mean time, I will address some of the more flaky resource-heavy tests as to try and streamline the process for other PRs |
As a quick fix, I was thinking we could first run the original logic to purge root level directories with zero changes, and then depend on the new logic just to clean the remaining directories further. Likely still some edge cases, but that would give us at least the best of both right in the meantime. |
TL;DR
Identified in 773, debugged in #777
After changes in #669, there are still samples that aren't pruned. This increases the CI execution time
Expected behavior
No response
Observed behavior
No response
Terraform Configuration
Terraform Version
Additional information
No response
The text was updated successfully, but these errors were encountered: