Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a verifier for Reduce ops that computes expected output shape #1639

Open
mrakitaTT opened this issue Dec 18, 2024 · 0 comments
Open

Add a verifier for Reduce ops that computes expected output shape #1639

mrakitaTT opened this issue Dec 18, 2024 · 0 comments

Comments

@mrakitaTT
Copy link
Contributor

mrakitaTT commented Dec 18, 2024

In PR #1625 we are adding verifier for Reduce ops. In this verifier we should also add a check that depending on inputShape, reduceDims and keepDim computes the expected output shape and checks if it matches the actual output shape. This kind of check turns out to be really valuable when op is decomposed because it will usually require some data movement op that will change shape, and this is the best place to catch those kinds of errors.

Here is the stablehlo implementation of the same verifier check for the reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant