Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Reduce logger verbosity for test runs #921 #966

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[CI] Reduce logger verbosity for test runs #921 #966

wants to merge 1 commit into from

Conversation

nvukobratTT
Copy link
Contributor

Fix #921

@nvukobratTT nvukobratTT enabled auto-merge (squash) December 26, 2024 09:12
pilkicTT
pilkicTT requested changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@pilkicTT pilkicTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should change the default -svv in pytest.ini to reduce log size.

However, that also has negative consequences on debugging failures (since the generated TTIR and TTNNIR won't be logged).

.github/workflows/build-and-test.yml

# Configure logging levels for the test
LOGGER_LEVEL: INFO
LOGURU_LEVEL: INFO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this the default logging level?

@nvukobratTT
Copy link
Contributor Author

I think we should change the default -svv in pytest.ini to reduce log size.

However, that also has negative consequences on debugging failures (since the generated TTIR and TTNNIR won't be logged).

Valid point. However, having all these details as part of log make it hard to interpret on daily basis (e.g. tracking and bisecting nightly run).

In order to preserve debugability, and still keep TT/TTNN IRs, maybe we should store them for each run (already existing feature) and just upload them as additional set of artifacts. @pilkicTT @vmilosevic what do you think guys?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pilkicTT pilkicTT pilkicTT requested changes

@vmilosevic vmilosevic Awaiting requested review from vmilosevic vmilosevic is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce logging in nightly run
2 participants
@nvukobratTT @pilkicTT