Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No shared memory for slice & cat #3

Open
denguir opened this issue Apr 13, 2024 · 0 comments
Open

No shared memory for slice & cat #3

denguir opened this issue Apr 13, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@denguir
Copy link
Collaborator

denguir commented Apr 13, 2024

Shared memory for slice & cat operator is cool but introduce too much complexity in the code. The idea behind that was that slice & cat would be used intensively inside other functions like reduce(axis) etc.

However, it seems that the complexity introduced is too big compared to the advantages it brings (aka iterator etc). Just put main branch into a side branch and rework slice & cat -> remove range attribute for tensors. Maybe create a TensorView struct for everything related to the iterator.

@denguir denguir added the enhancement New feature or request label Apr 13, 2024
@denguir denguir self-assigned this Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant