Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model analysis Tensorflow requirement issue #120

Closed
akewan opened this issue Apr 7, 2021 · 2 comments · May be fixed by #121
Closed

Model analysis Tensorflow requirement issue #120

akewan opened this issue Apr 7, 2021 · 2 comments · May be fixed by #121
Assignees
@mdreves
Labels
stat:awaiting tensorflower type:bug

Comments

@akewan
Copy link

akewan commented Apr 7, 2021

The requirment for Tensorflow in model analysis at:

model-analysis/setup.py

Line 303 in 67a4d96

'tensorflow>=1.15.2,!=2.0.*,!=2.1.*,!=2.2.*!=2.3.*,<3',

is incorrect. A coma is missing before "!=2.3.*" as it is at TFX install requirments:
https://github.com/tensorflow/tfx/blob/21e5af7f9543e108328c1a83b9132acda4875d93/tfx/dependencies.py#L88
This missing come reinstalls an already installed version of Tensorflow 2.4.0 and installs a 2.4.1 version of it
@arghyaganguly arghyaganguly self-assigned this Apr 8, 2021
@arghyaganguly
Copy link

@akewan , thanks for reporting this bug.A PR has been raised to address it.Thanks.

@arghyaganguly arghyaganguly mentioned this issue Apr 14, 2021
Open
@dhruvesh09
Copy link
Contributor

This is been addressed in
19d49dc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdreves mdreves

Labels
stat:awaiting tensorflower type:bug
Projects
None yet
Milestone
No milestone
4 participants
@mdreves @akewan @dhruvesh09 @arghyaganguly