From fd9b48bda93eb032fbcca9343d7ae0da6cf3ab64 Mon Sep 17 00:00:00 2001 From: Monica Song Date: Wed, 11 Jan 2023 23:11:43 +0000 Subject: [PATCH 1/3] add experimental --- rfcs/20220610-saved-model-fingerprinting.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rfcs/20220610-saved-model-fingerprinting.md b/rfcs/20220610-saved-model-fingerprinting.md index ddfe56ecb..b5a35659a 100644 --- a/rfcs/20220610-saved-model-fingerprinting.md +++ b/rfcs/20220610-saved-model-fingerprinting.md @@ -184,7 +184,7 @@ One drawback of having a separate file is that it is a potentially significant c All fingerprints will be written to disk automatically, and there is no way to bypass or customize writing fingerprints when serializing a SavedModel. -There will be a public API in python `tf.saved_model.read_fingerprint(export_dir)` which returns a dictionary mapping the names of the fields in the protobuf (i.e. "saved_model_checksum", "graph_def_program_hash", "signature_def_hash", "saved_object_graph_hash", "checkpoint_hash", "version") to their values. +There will be a public API in python `tf.saved_model.read_fingerprint(filepath)` which returns a dictionary mapping the names of the fields in the protobuf (i.e. "saved_model_checksum", "graph_def_program_hash", "signature_def_hash", "saved_object_graph_hash", "checkpoint_hash", "version") to their values. ### Validation From 8bf4bb8ac8417f68f1ff44af0943de766fbafe36 Mon Sep 17 00:00:00 2001 From: Monica Song Date: Wed, 11 Jan 2023 23:26:42 +0000 Subject: [PATCH 2/3] experimental --- rfcs/20220610-saved-model-fingerprinting.md | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/rfcs/20220610-saved-model-fingerprinting.md b/rfcs/20220610-saved-model-fingerprinting.md index b5a35659a..1e7162bf9 100644 --- a/rfcs/20220610-saved-model-fingerprinting.md +++ b/rfcs/20220610-saved-model-fingerprinting.md @@ -1,11 +1,11 @@ # SavedModel Fingerprinting -| Status | Accepted | +| Status | Proposed | :-------------- |:---------------------------------------------------- | | **RFC #** | 415 | | **Author(s)** | Monica Song (monicadsong@google.com) | | **Sponsor** | Cesar Crusius (ccrusius@google.com) | -| **Updated** | 2022-06-10 | +| **Updated** | 2023-01-11 | ## Objective @@ -184,7 +184,10 @@ One drawback of having a separate file is that it is a potentially significant c All fingerprints will be written to disk automatically, and there is no way to bypass or customize writing fingerprints when serializing a SavedModel. -There will be a public API in python `tf.saved_model.read_fingerprint(filepath)` which returns a dictionary mapping the names of the fields in the protobuf (i.e. "saved_model_checksum", "graph_def_program_hash", "signature_def_hash", "saved_object_graph_hash", "checkpoint_hash", "version") to their values. +There will be an API in python `tf.saved_model.read_fingerprint(export_dir)` which returns a `Fingerprint` object +(`tf.saved_model.Fingerprint`) containing the values of the fingerprint. + +Following convention, these two new public APIs will be released under the "experimental" namespace, i.e. `tf.saved_model.experimental` and then graduate to non-experimental when stable. ### Validation From 692c0e6f2f243ce2a22f9ec851a600649aedd62d Mon Sep 17 00:00:00 2001 From: Monica Song Date: Wed, 11 Jan 2023 23:35:19 +0000 Subject: [PATCH 3/3] accidentally changed status --- rfcs/20220610-saved-model-fingerprinting.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rfcs/20220610-saved-model-fingerprinting.md b/rfcs/20220610-saved-model-fingerprinting.md index 1e7162bf9..56cc48e5c 100644 --- a/rfcs/20220610-saved-model-fingerprinting.md +++ b/rfcs/20220610-saved-model-fingerprinting.md @@ -1,6 +1,6 @@ # SavedModel Fingerprinting -| Status | Proposed | +| Status | Accepted | :-------------- |:---------------------------------------------------- | | **RFC #** | 415 | | **Author(s)** | Monica Song (monicadsong@google.com) |