Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include command info when command fails validation #6896

Open
tsurdilo opened this issue Nov 27, 2024 · 0 comments
Open

Include command info when command fails validation #6896

tsurdilo opened this issue Nov 27, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@tsurdilo
Copy link
Contributor

tsurdilo commented Nov 27, 2024

Currently when handling schedule activity task command from workflow task completion
we check payload size limit, but do not log the command info (activity type would be great) as part of the error info, for example:

       return nil, nil, handler.terminateWorkflow(enumspb.WORKFLOW_TASK_FAILED_CAUSE_BAD_SCHEDULE_ACTIVITY_ATTRIBUTES, err)

here err does not include any info about the offending activity, would be great to have this info if possible as would make debugging easier

@tsurdilo tsurdilo added the enhancement New feature or request label Nov 27, 2024
@tsurdilo tsurdilo changed the title Return info on command that ran into payload seize exceeds limit issue Include command info when command fails validation Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant