Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make option for UpsertSearchAttribute command to fail if SA does not exists #6647

Open
yiminc opened this issue Oct 11, 2024 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@yiminc
Copy link
Member

yiminc commented Oct 11, 2024

Is your feature request related to a problem? Please describe.
Currently, if workflow try to upsert SA from within the workflow and it does not exists, the workflow task will fail and keep retrying forever.

Describe the solution you'd like
Give option for workflow to fail the command if SA does not exists

Describe alternatives you've considered
Work around is to use activity/localActivity to check if SA exists before call upsertSA.
But really the author should make sure the SA exists before the use case go online. Create SA should be handed as one time job and should not be created dynamicly. If you find that you need to create SA dynamicly, you probably doing it wrong. The number of SA is very limited.

Additional context
Add any other context or screenshots about the feature request here.

@yiminc yiminc added the enhancement New feature or request label Oct 11, 2024
@drewhoskins-temporal
Copy link
Contributor

Given that there's a workaround, we have put this on the backlog for now and will not get to it any time soon. Please bump this issue if you'd like to vote for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants