feat(worker): expose AbortController to the worker sandbox #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeramsden
commented
Nov 28, 2024
| @@ -86,6 +86,7 @@ export class VMWorkflowCreator implements WorkflowCreator { | |||
| __webpack_module_cache__: {}, | |||
| TextEncoder, | |||
| TextDecoder, | |||
| AbortController, | |||
There was a problem hiding this comment.
I couldn't get a test to falsify this change - only the change in reusable-vm makes the tests pass or fail. Is there something I'm missing in terms of how to get this VM class to be the one that's used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Exposed AbortController builtin to the sandbox
Why?
Checklist
Closes [Feature Request] Expose
AbortControllerin Workflow sandbox #1564How was this tested:
Tested locally and with a test