Ignore PHP dependencies constrain in CI when PHP 8.4 is used

temporalio · Dec 9, 2024 · 852d08d · 852d08d
1 parent 9b3feb4
commit 852d08d
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 8 deletions.
diff --git a/.github/workflows/run-test-suite.yml b/.github/workflows/run-test-suite.yml
@@ -91,20 +91,30 @@ jobs:
             php-${{ matrix.php }}-${{ matrix.os }}-composer-
 
       - name: Install lowest dependencies from composer.json
-        if: matrix.dependencies == 'lowest'
+        if: matrix.dependencies == 'lowest' == 'highest' && matrix.php != '8.4'
         run: composer update --no-interaction --no-progress --prefer-lowest
 
+      - name: Install lowest dependencies from composer.json
+        if: matrix.dependencies == 'lowest' == 'highest' && matrix.php == '8.4'
+        run: composer update --no-interaction --no-progress --prefer-lowest --ignore-platform-req php
+
+
       - name: Validate lowest dependencies
         if: matrix.dependencies == 'lowest'
         env:
           COMPOSER_POOL_OPTIMIZER: 0
         run: vendor/bin/validate-prefer-lowest
 
+
       - name: Install highest dependencies from composer.json
-        if: matrix.dependencies == 'highest'
+        if: matrix.dependencies == 'highest' && matrix.php != '8.4'
         run: composer update --no-interaction --no-progress
 
-      - name: Download RoadRunner
+      - name: Install highest dependencies from composer.json
+        if: matrix.dependencies == 'highest' && matrix.php == '8.4'
+        run: composer update --no-interaction --no-progress --ignore-platform-req php
+
+      - name: Download binaries
         if: inputs.download-binaries == true
         run: composer get:binaries
 

diff --git a/composer.json b/composer.json
@@ -61,7 +61,6 @@
         "phpunit/phpunit": "^10.5",
         "spiral/code-style": "~2.1.2",
         "spiral/core": "^3.13",
-        "symfony/var-dumper": "^6.0 || ^7.0",
         "ta-tikoma/phpunit-architecture-test": "^0.8.4",
         "vimeo/psalm": "^4.30 || ^5.4"
     },

diff --git a/tests/Unit/Exception/FailureConverterTestCase.php b/tests/Unit/Exception/FailureConverterTestCase.php
@@ -72,10 +72,17 @@ public function testStackTraceStringForAdditionalContextEvenWhenClassIsNotPresen
             $trace,
         );
 
-        self::assertStringContainsString(
-            'Temporal\Tests\Unit\Exception\FailureConverterTestCase->Temporal\Tests\Unit\Exception\{closure}()',
-            $trace,
-        );
+        if (\PHP_VERSION_ID < 80400) {
+            self::assertStringContainsString(
+                'Temporal\Tests\Unit\Exception\FailureConverterTestCase->Temporal\Tests\Unit\Exception\FailureConverterTestCase::testStackTraceStringForAdditionalContextEvenWhenClassIsNotPresented():63',
+                $trace,
+            );
+        } else {
+            self::assertStringContainsString(
+                'Temporal\Tests\Unit\Exception\FailureConverterTestCase->{closure:Temporal\Tests\Unit\Exception\FailureConverterTestCase::testStackTraceStringForAdditionalContextEvenWhenClassIsNotPresented():63',
+                $trace,
+            );
+        }
 
         self::assertStringContainsString(
             'call_user_func(Closure)',