update README from tctl to Temporal CLI #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
aarohib
reviewed
Oct 12, 2024
dandavison
approved these changes
Oct 14, 2024
codec-server/README.md
Outdated
| @@ -1,31 +1,32 @@ | |||
| ### Steps to run this sample: | |||
|
|
|||
| This sample shows how to decode payloads that have been encoded by a codec so they can be displayed by tctl and Temporal Web. | |||
| This sample shows how to decode payloads that have been encoded by a codec so they can be displayed by the Temporal CLI and Temporal Web. | |||
There was a problem hiding this comment.
nit: none of this is your responsibility but if you don't mind I'm thinking "Temporal UI" is the proper name (e.g. https://docs.temporal.io/evaluate/major-components) -- could be worth changing throughout.
There was a problem hiding this comment.
awesome! I was looking for a proper name guide. I updated it in dbe80fb. Please take a look 🙏
Co-authored-by: Dan Davison <[email protected]>
Co-authored-by: Dan Davison <[email protected]>
Co-authored-by: Dan Davison <[email protected]>
Co-authored-by: Dan Davison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
tctlhas been depreciated,temporalCLI replaces it.Why?
How was this tested:
Manually
Any docs updates needed?
Updated the docs!