Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed or interrupted downloads leaves corrupted template files. #53

Open
bpinsard opened this issue Jun 19, 2020 · 2 comments
Open

Failed or interrupted downloads leaves corrupted template files. #53

bpinsard opened this issue Jun 19, 2020 · 2 comments

Comments

@bpinsard
Copy link

If a templateflow image download fails, the truncated file is non-zero and considered as fetched and returned in subsequent queries.

This occurred in a rare case where the truncated image silently propagated through Ants-based resampling and subsequent brain extraction, corrupting the whole pipeline.
nipreps/fmriprep#2192
It seems that it was using the default non-datalad download.

An option would be to checksum-validate each time the template is queried.

@oesteban
Copy link
Member

Using the datalad backend this should not occur. I'm not sure it is worth the pain maintaining a MANIFEST file with MD5 sums. Perhaps we could reconsider making datalad the default since it is more stable now?

@oesteban
Copy link
Member

Opening with nibabel could be an easy tradeoff between today and a decent validation of checksums.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants