Opening the tdesktop architecture: planning: pure virtual class chat

[nonlin-lin-chaos-order-etc-etal]

Folks, what do you think about this: libregram#1 : I'd like to create a pull request into this (your) tdesktop repo, with changes/additions described below (no code changes currently done, I plan this). I'd like to add allowing for custom implementations for every chat (for every tdesktop gui chatlist entry): create pure virtual class chat with horde of pure virtual methods. And implement standard tg chats through this abstract class.

Will you merge this work (pull request) in, if perfectly done? I've not yet studied the tdesktop code.

[john-preston]

I'm not sure this is possible in tdesktop. I think you'd better look into the code first for better understanding what you want to do there exactly. For example, there is no such thing as "gui chatlist entry" and I can't imagine what you could really customize in chats list through plugins.

[stek29]

And I don't think such virtual class based approach is a good way to implement plugin system.
Even if it was, this is a perfect example of PRs which don't really fit well with "What contributions are accepted?"

Anyway, see #472.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.