Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve msnodesqlv8 documentation in README #1652

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

imjosh
Copy link
Contributor

@imjosh imjosh commented Jun 3, 2024

What this does:

  • Clarify documentation on how to use the msnodesqlv8 driver
  • Explicitly document which driver is required for Windows/Trusted Connection Authentication & provide example code
  • Refer to msnodesqlv8 exclusively by its package name

Related issues:

N/A

Pre/Post merge checklist:

  • Update change log

@imjosh imjosh changed the title Update README.md Improve msnodesqlv8 documentation in README Jun 3, 2024
@imjosh imjosh marked this pull request as ready for review June 3, 2024 19:09
@dhensby
Copy link
Collaborator

dhensby commented Jun 3, 2024

Thanks, these commits won't pass the commit linting.

Please can you squash the commits and reword them to something like: docs: update msnodesqlv8 related docs

-Clarify documentation on how to use the msnodesqlv8 driver
-Explicitly document which driver is required for Windows/Trusted Connection Authentication & provides example code for it
-Refer to msnodesqlv8 by its package name
@dhensby dhensby force-pushed the improve-msnodesqlv8-documentation branch from ae67667 to e35aed7 Compare June 18, 2024 22:47
@dhensby dhensby merged commit b27d34c into tediousjs:master Jun 18, 2024
45 checks passed
Copy link

github-actions bot commented Jul 3, 2024

🎉 This PR is included in version 11.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants