From eb3e4d00d9ef243d33d546e71bffc95948f77617 Mon Sep 17 00:00:00 2001 From: partik-mis Date: Tue, 5 Sep 2023 15:00:43 -0400 Subject: [PATCH 1/2] fix: msnodesqlv8 connection string uses correct instance name driver was not using the correct option for instanceName and so it was undefined rather than the correct value. --- lib/msnodesqlv8/connection-pool.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/msnodesqlv8/connection-pool.js b/lib/msnodesqlv8/connection-pool.js index 7ffa7012..bd147cbc 100644 --- a/lib/msnodesqlv8/connection-pool.js +++ b/lib/msnodesqlv8/connection-pool.js @@ -24,7 +24,7 @@ class ConnectionPool extends BaseConnectionPool { if (!this.config.connectionString) { cfg.conn_str = buildConnectionString({ Driver: CONNECTION_DRIVER, - Server: this.config.options.instanceName ? `${this.config.server}\\${this.config.instanceName}` : `${this.config.server},${this.config.port}`, + Server: this.config.options.instanceName ? `${this.config.server}\\${this.config.options.instanceName}` : `${this.config.server},${this.config.port}`, Database: this.config.database, Uid: this.config.user, Pwd: this.config.password, From ff05cceb83f2f0c33bfaff6df5410eefa615337b Mon Sep 17 00:00:00 2001 From: Dan Hensby Date: Tue, 5 Sep 2023 21:44:03 +0100 Subject: [PATCH 2/2] docs: update changelog --- CHANGELOG.txt | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.txt b/CHANGELOG.txt index cc3a2251..0093c77b 100644 --- a/CHANGELOG.txt +++ b/CHANGELOG.txt @@ -1,4 +1,20 @@ -v9.1.3 (2023-??-??) +v9.3.1 (2023-09-05) +------------------- +[fix] Fix bug with msnodesqlv8 connection strings ((#1525)[https://github.com/tediousjs/node-mssql/pull/1525]) + +v9.3.0 (2023-09-04) +------------------- +[new] Add AAD connection support to connection strings ((#1461)[https://github.com/tediousjs/node-mssql/pull/1461]) + +v9.2.1 (2023-09-05) +------------------- +[fix] Fix bug with msnodesqlv8 connection strings ((#1525)[https://github.com/tediousjs/node-mssql/pull/1525]) + +v9.2.0 (2023-08-28) +------------------- +[new] Use @tediousjs/connection-string library to build msnodesqlv8 connection strings ((#1525)[https://github.com/tediousjs/node-mssql/pull/1525]) + +v9.1.3 (2023-08-08) ------------------- [fix] Escape values that are added to the msnodesqlv8 connection string that we construct ((#1479)[https://github.com/tediousjs/node-mssql/pull/1479])