Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistencies between pool and item #363

Open
theluk opened this issue Aug 13, 2017 · 0 comments
Open

inconsistencies between pool and item #363

theluk opened this issue Aug 13, 2017 · 0 comments

Comments

@theluk
Copy link

theluk commented Aug 13, 2017

The namespace and the driver in Stash\Interface\PoolInterface are not immutable but they are not delegated to the underlying Stash\Interface\ItemInterface. Changing the driver or the namespace lead to a inconsistency between Pool and Item.

Solution 1: setDriver and setNamespace MUST be removed
Solution 2: Driver and Namespace changes MUST be propagated down to all Items. This would mean, that the state of the item would be invalid. Therefore it MUST be fully reloaded or instantiated.

The easiest and cleanest part would be Solution 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant