Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect image height #22

Open
Id2ndR opened this issue Nov 9, 2016 · 0 comments
Open

Incorrect image height #22

Id2ndR opened this issue Nov 9, 2016 · 0 comments

Comments

@Id2ndR
Copy link

Id2ndR commented Nov 9, 2016

CSS set ".remark-slide-content img" height with value "42vh !important". This relative size of 42% on Viewport height, with I expect to be 42% oh the "slide" height is not render as it should be.

I'm not sure if it is a browser issue, a remark one or a slides-in-markdown one, so I report in the end-user software. I got the same behavior in Firefox and Chrome.

Test case:

  • open a bowser with a slide containing an image
  • use developer mode of the browser, to get the actual heigh of the viewport and the image. Compute the ratio on these and compare to 42%
  • resize the browser window to half it size in height. Compute again the new ratio and compare.

Expected results: get the 42% ratio in both previous cases.
Actual result: then the browser window is full screen, the ratio is bigger that expected (47% in my case), and a lot smaller with a small window (about 20% with a window height of half the height on my screen).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant