Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ConnectedPacket::serialized_size with Serialize::size_hint #249

Open
RadiatedMonkey opened this issue Feb 1, 2024 · 0 comments
Open

Replace ConnectedPacket::serialized_size with Serialize::size_hint #249

RadiatedMonkey opened this issue Feb 1, 2024 · 0 comments
Labels
A-protocol Area: game protocol C-refactor Category: refactor of existing code E-large Call for participation. This issue needs a lot of refactoring to fix

Comments

@RadiatedMonkey
Copy link
Member

RadiatedMonkey commented Feb 1, 2024 •
edited
Loading

The serialized_size function should be removed and replaced by the new size_hint function in the Serialize trait which will automatically allocate before serializing.
@RadiatedMonkey RadiatedMonkey self-assigned this Feb 1, 2024
@RadiatedMonkey RadiatedMonkey added C-refactor Category: refactor of existing code E-large Call for participation. This issue needs a lot of refactoring to fix and removed C-enhancement labels Feb 11, 2024
@RadiatedMonkey RadiatedMonkey removed their assignment Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-protocol Area: game protocol C-refactor Category: refactor of existing code E-large Call for participation. This issue needs a lot of refactoring to fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RadiatedMonkey