From d5c2fa5771e22dfea8e84ead4a83d3c5feb24b91 Mon Sep 17 00:00:00 2001 From: Olivier Combe Date: Thu, 7 Dec 2023 14:01:43 +0100 Subject: [PATCH] fix: skiplibcheck for the preview --- angular/devkit/compiler/ng-packagr/ng-packagr.compiler.ts | 8 +++----- .../devkit/preview/preview/preview-app/tsconfig.app.json | 7 +------ 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/angular/devkit/compiler/ng-packagr/ng-packagr.compiler.ts b/angular/devkit/compiler/ng-packagr/ng-packagr.compiler.ts index 14fed971..f71680c4 100644 --- a/angular/devkit/compiler/ng-packagr/ng-packagr.compiler.ts +++ b/angular/devkit/compiler/ng-packagr/ng-packagr.compiler.ts @@ -21,12 +21,10 @@ import { CyclicError } from '@teambit/graph.cleargraph'; import { IsolatorAspect, IsolatorMain } from '@teambit/isolator'; import { PACKAGE_JSON } from '@teambit/legacy/dist/constants'; import PackageJsonFile from '@teambit/legacy/dist/consumer/component/package-json-file'; -import removeFilesAndEmptyDirsRecursively - from '@teambit/legacy/dist/utils/fs/remove-files-and-empty-dirs-recursively'; import { Logger } from '@teambit/logger'; import { Workspace } from '@teambit/workspace'; import chalk from 'chalk'; -import { mkdirsSync, outputFileSync } from 'fs-extra'; +import { mkdirsSync, outputFileSync, removeSync } from 'fs-extra'; import type { NgPackageConfig } from 'ng-packagr/ng-package.schema'; import { join, posix, resolve } from 'path'; import { Diagnostic, DiagnosticCategory, DiagnosticWithLocation } from 'typescript'; @@ -239,8 +237,8 @@ export class NgPackagrCompiler implements Compiler { packageJson.mergePackageJsonObject(jsonProps); await packageJson.write(); // delete the [ng-]package.json file generated by ngPackagr - await removeFilesAndEmptyDirsRecursively([resolve(join(pathToOutputFolder, this.distDir, PACKAGE_JSON))]); - await removeFilesAndEmptyDirsRecursively([resolve(ngPackageJsonPath)]); + removeSync(resolve(join(pathToOutputFolder, this.distDir, PACKAGE_JSON))); + removeSync(resolve(ngPackageJsonPath)); // eslint-disable-next-line consistent-return }, async(err: Error) => { if (err.message === ViewEngineTemplateError && !tsCompilerOptions.fullTemplateTypeCheck) { diff --git a/angular/devkit/preview/preview/preview-app/tsconfig.app.json b/angular/devkit/preview/preview/preview-app/tsconfig.app.json index c81463bc..7263ce21 100644 --- a/angular/devkit/preview/preview/preview-app/tsconfig.app.json +++ b/angular/devkit/preview/preview/preview-app/tsconfig.app.json @@ -5,12 +5,6 @@ "allowJs": true, "allowSyntheticDefaultImports": true, "baseUrl": "./", - "outDir": "./dist/out-tsc/app", - "forceConsistentCasingInFileNames": true, - "strict": true, - "noImplicitReturns": true, - "noFallthroughCasesInSwitch": true, - "sourceMap": true, "declaration": false, "downlevelIteration": true, "experimentalDecorators": true, @@ -27,6 +21,7 @@ "noImplicitReturns": true, "outDir": "./dist/out-tsc/app", "preserveSymlinks": false, + "skipLibCheck": true, "sourceMap": true, "strict": true, "target": "es5"