Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

django-memoize vs. memoize #23

Open
anx-ckreuzberger opened this issue Oct 3, 2017 · 4 comments
Open

django-memoize vs. memoize #23

anx-ckreuzberger opened this issue Oct 3, 2017 · 4 comments

Comments

@anx-ckreuzberger
Copy link

There is a pypi package called "memoize" (which exists since at least 2013), while there also is "django-memoize" (this package). However, the module in this package is called "memoize", which is conflicting with the existing pypi package.

One could accidentally do a "pip install memoize", which would result in the following error message when you run your code:

from memoize import memoize, delete_memoized, delete_memoized_verhash
ImportError: cannot import name 'memoize'

Though the worst part of this is when you consider recent squatting events on pypi, where people register "fake" packages with malicious code (see https://www.pytosquatting.org/ for more details, in case you missed it).

There is no imminent threat for django-memoize, but I would like to begin a discussion about renaming the module in this package to "django_memoize", so that it matches the package name.

Any thoughts on this from others?

@unformatt
Copy link

Agreed. I see memoize in my code. I see memoize in my site-packages. So I search internet for python memoize github. I find https://github.com/rlgomes/memoize. Very confusing.

@jimmy927
Copy link

One could accidentally do a "pip install memoize", which would result in the following error message when you run your code:

I just did that and got very confused until i found this post :-)

@anx-ckreuzberger
Copy link
Author

That means this post can now be found via search engines :D

@PetrDlouhy
Copy link

This means, that django-memoize and memoize can't be used in one project even as dependency of other module. The django-admin-charts broke other application when I added django-memoize as dependency:
PetrDlouhy/django-admin-charts@758b580#r87232967

PetrDlouhy referenced this issue in PetrDlouhy/django-admin-charts Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants