Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent a template from being deleted if it is in use #113

Closed
netwolfuk opened this issue Sep 5, 2018 · 3 comments
Closed

Prevent a template from being deleted if it is in use #113

netwolfuk opened this issue Sep 5, 2018 · 3 comments
Labels
available in alpha or beta release item is released in a "pre-release" version ready for testing. bug waiting for release
Milestone

Comments

@netwolfuk
Copy link
Member

Expected Behaviour

  • Should not be ale to delete a template, if there is a webhook using it.

Current Behaviour

  • Template can be deleted with no checks.
@netwolfuk netwolfuk added this to the v1.2 milestone Sep 5, 2018
@netwolfuk netwolfuk added the bug label Sep 5, 2018
@netwolfuk netwolfuk changed the title Prevent a template form being deleted if it's in use Prevent a template from being deleted if it is in use Sep 5, 2018
@netwolfuk
Copy link
Member Author

netwolfuk commented Jan 2, 2019

Create WebHook settings manager which provides the following.

  1. CRUD webhooks via this manager.
  2. Ability to find all webhooks (grouped by project tree somehow).
  3. Ability to find webhooks by project, buildEvent, buildType, templateId, tag (see Add a label to webhook configuration #116), authType.
  4. Ability to find webhooks by url (substring).
  5. Ability to find only enabled webhooks along with above filters. Eg, show me webhooks that will actually fire for this specific buildType.
  6. "full text search" eg, just start typing and it will find any matching webhooks. Should search tags, url, buildTypeName, buildTypeExternalId, projectName, projectExternalId. These could be "tags" and "url" and could be cached.
  7. Quick (cached) results for count of webhooks, by project, by template, etc. These should be updated on each webhook write (async).

Returned results should include the following so that they can be displayed in UI:

  1. match reason(s).
  2. events enabled
  3. buildTypes enabled
  4. tags
  5. url
  6. template-id

Clicking a webhook should allow direct editing, not via some page when then requires finding and clicking again.

@netwolfuk
Copy link
Member Author

netwolfuk commented Aug 26, 2019

Item 3 is not done yet.

@netwolfuk
Copy link
Member Author

This is available for testing in the v1.2.0-alpha.3 release.

@netwolfuk netwolfuk added the available in alpha or beta release item is released in a "pre-release" version ready for testing. label Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
available in alpha or beta release item is released in a "pre-release" version ready for testing. bug waiting for release
Projects
None yet
Development

No branches or pull requests

1 participant