Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Signal.subtle.Watcher.prototype.watch(...signals)" phase 4 is vague #205

Open
prophile opened this issue Apr 29, 2024 · 1 comment
Open

Comments

@prophile
Copy link
Contributor

In "Method: Signal.subtle.Watcher.prototype.watch(...signals)" we have:

  1. Add this watcher as a sink to each Signal. If this was the first sink, then recurse up to sources to add that signal as a sink, and call the watched callback if it exists.

It's not immediately clear for the first sentence whether this means the newly watched signals (which is spelled out explicitly in phase 3 immediately beforehand) or all sources.

It's also not clear what "recurse up to the sources" means; especially with the watched callback being called I think it's worth being quite explicit about the algorithm and ordering here.

@littledan
Copy link
Member

@prophile to fix this wording

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants