Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: do not duplicate code in Solve overloads #4

Open
AndrewSav opened this issue Aug 22, 2018 · 0 comments
Open

Improvement: do not duplicate code in Solve overloads #4

AndrewSav opened this issue Aug 22, 2018 · 0 comments

Comments

@AndrewSav
Copy link

Admittedly, Solve methods are all quite small, but it appears that some of them duplicate code in others, whereas they can be just calling the overload which code it's duplicating.

Ideally only a single overload should call Search (and BuildInternalStructure) and the reset should call this overload (possibly via another overload call, in a chain).

Overall I salute you for solution meticulously crafted, very well done, but this thing stood out for me, may be there is a reason for this, that I failed to see?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant