Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyTorch version code is available. Thank wvinzh! #15

Open
wvinzh opened this issue Nov 14, 2019 · 7 comments
Open

PyTorch version code is available. Thank wvinzh! #15

wvinzh opened this issue Nov 14, 2019 · 7 comments

Comments

@wvinzh
Copy link

wvinzh commented Nov 14, 2019

I run the tf code and got a 89+% acc, I think my implementation is almost the same as your tf version, so is there any details that you didn't mentioned in the paper?

@wvinzh
Copy link
Author

wvinzh commented Nov 21, 2019

pytorch version result:

Dataset ACC ACC Refine
CUB-200-2011 87.401 87.487
Stanford Cars 92.837 93.595
FGVC-Aircraft 89.319 89.769

@tau-yihouxiang
Copy link
Owner

All details are shown in this code. You can check the improvement of each module according to the table in the paper. In my experiment, attention regularization or center loss and feature scale are pretty important, which might be different between TensorFlow and PyTorch.

@Danbinabo
Copy link

embeddings = end_points_1['embeddings']这里报错,KeyError: 'embeddings'这里是取的那一层的特征图啊?谢谢!

@wvinzh
Copy link
Author

wvinzh commented Nov 27, 2019

@tau-yihouxiang Thanks a lot! I found i ignored normalization when calculating center loss, and now i got 89.2% acc

@tau-yihouxiang
Copy link
Owner

@wvinzh Congratulations!

@wvinzh
Copy link
Author

wvinzh commented Nov 30, 2019

PyTorch version code is available: WS_DAN_PyTorch

@tau-yihouxiang
Copy link
Owner

@wvinzh For Stanford-Dog, you can try Mixed_7c instead of Mixed_6e as shown in train_sample_dog.sh

@tau-yihouxiang tau-yihouxiang changed the title Reimplement the model in Pytorch, only get 87.487% acc on CUB-200-2011 PyTorch version code is available. Thank wvinzh! Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants