Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build from scratch or migrate existing app? #5

Open
addyosmani opened this issue Dec 11, 2020 · 8 comments
Open

Build from scratch or migrate existing app? #5

addyosmani opened this issue Dec 11, 2020 · 8 comments
Labels
question Further information is requested

Comments

@addyosmani
Copy link
Member

There may be value in us taking an existing TMDB implementation in Vue or Nuxt and 'porting' it over to the latest Nuxt then work on our optimizations from there.

One benefit over beginning from scratch is that some of the views are already in place and we can see what dependencies (or slip-ups it can be common to make when building an app) that may otherwise not be visible if we're starting from scratch on our own. Do folks have opinions on this?

https://github.com/jasonujmaalvis/vue-movies is one good existing app. Based on #3, if we went in this direction we would still want to add support for auth and so on.

@addyosmani addyosmani added the question Further information is requested label Dec 11, 2020
@pi0
Copy link
Member

pi0 commented Dec 12, 2020

vue-movies seems a really neat candidate and since it is already built with nuxt2 we mostly need to do some code cleanups aligning with latest version of nuxt. We also took porting strategy for nuxt/hackernews in past :)

Only as there is no LICENSE file in vue-movies repository, I will start with a fork of that repo until we decide finally use it or not.

Comparing movies.zaps.dev and movies.jason.codes it seems the first on is focusing on a bare minimal example. Is it fine to go with more complex implementation or finally comparation would be one of your goals?

@addyosmani
Copy link
Member Author

Thanks @pi0! This sounds great to me.

To help out with the implementation we've asked @anton-karlovskiy to kick off a port of the app soon but we would love as much help as we can get once we've started digging into initial optimizations for LCP, CLS etc. Would you be open to us tagging you in as we start to run into questions? :)

@pi0
Copy link
Member

pi0 commented Dec 12, 2020

For sure feel free tagging me and daniel for any help we could do :) And it is much better what Anton is going to do to find out real user experience.

BTW i will finish vue-movies upgrade today in a fork so you can use it as a reference for porting app (adding both web-vitals and image module is pending for release)

@anton-karlovskiy
Copy link
Member

Thank you @addyosmani @pi0 for your input.

I'm going to work on the upgraded vue-movies project once @pi0 has finished upgrading it.

@addyosmani
Copy link
Member Author

@pi0 When you feel you're far ahead enough with your port, would you like to link up to it or PR it into this repo? Anton would be happy to dive in once it's ready :)

@anton-karlovskiy
Copy link
Member

@addyosmani @pi0
I've already started working on this project.
@pi0 If you have anything to be done to the original project in mind, could you please share with me through this issue tracker?
Then I can realize it.

@pi0
Copy link
Member

pi0 commented Dec 22, 2020

Hi @anton-karlovskiy. Sorry I've been inactive for few days. Sure, Actually there are few more improvements coming to my fork which I wish we used same git history to be able doing rebase but i will keep you updated with list of important changes if wanted to apply :)

@anton-karlovskiy
Copy link
Member

Hi @pi0
Thank you for the update.

i will keep you updated with list of important changes if wanted to apply

This sounds good to me.
Actually, I've started pushing changes to this repository.

FYI: Your changes are added as an initial commit.
b0d414a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants