Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preconnects to required origins like https://image.tmdb.org and http://fonts.gstatic.com #17

Open
anton-karlovskiy opened this issue Jan 17, 2021 · 5 comments
Assignees

Comments

@anton-karlovskiy
Copy link
Member

anton-karlovskiy commented Jan 17, 2021

Re: https://googlechrome.github.io/lighthouse/viewer/?gist=45a455e15a2d1c5ae12b5c37404e953b
preconnects

cc @addyosmani

@addyosmani
A preconnect to https://image.tmdb.org is added.
http://fonts.gstatic.com does not have to be added as it's handled by the @nuxtjs/google-fonts.

@anton-karlovskiy
Copy link
Member Author

@addyosmani @pi0
I think we can close this issue.

@addyosmani
Copy link
Member

@anton-karlovskiy Is this issue highlighting that these changes already landed? If so, I think it's fair to close it.

@anton-karlovskiy
Copy link
Member Author

@addyosmani

A preconnect to https://image.tmdb.org is added.
http://fonts.gstatic.com does not have to be added as it's handled by the @nuxtjs/google-fonts.

@pi0
Copy link
Member

pi0 commented Mar 28, 2021

Also note that preconnect to tmdb is not required either (since we proxy under same sub-domain).

BW there is an open issue in nuxt-image repo to automatically generate preconnect metas when specified (can be useful for on-demand external images like youtube thumbnail)

@anton-karlovskiy
Copy link
Member Author

anton-karlovskiy commented Mar 28, 2021

@pi0 cc @addyosmani
Thank you for letting me know.
Then I will drop the preconnect to https://image.tmdb.org for now. -> It's done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants