-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Measuring Core Web Vitals (RUM) #1
Comments
Hi Addy, indeed that is the module. We moved best community implementation to |
That sounds promising. Thanks so much, @pi0! 😄 |
[refactor] push the changes done by Pooya
Hi @addyosmani @pi0 @danielroe Could you please pause merging any PRs to the dev branch until we have set up measurement integrations like Lighthouse or WebPageTest etc? Now as we have set up Vercel configuration, we can obtain a unique URL for a PR. I think it's very important for us to know whether a specific PR brings improvement or regression in the performance so that we can make sure that our optimization approaches have been right and correct them if a regression occurs at an early stage. I think we can set up an automatic measuring process as a CI/CD action.
I'm going to dig into which one is fit for us. @addyosmani I'd like your suggestions here. :) |
Thanks Anton. In this case, I think Lighthouse CI using GitHub actions might be the perfect fit for continuous performance recordings. When I've used them, I've found the clear "diff" of user-experience changes in the enhanced Lighthouse CI report to help me understand what metrics or audits were seeing a shift. Perhaps for this project, we can setup Lighthouse CI and only do periodic checks using WebPageTest where we feel we really need to be able to compare the filmstrip or waterfalls the way they visually present them? |
Hi @addyosmani
On the other hand, it appears that the Lighthouse integration via Vercel provides all we need: What are your thoughts? |
You can set up a GitHub Actions workflow that triggers on Vercel deployments - it will receive the unique preview URL from Vercel and you can then run lhci (via Action or custom script) against that deployment URL. |
@danielroe Thank you for your information. We have already integrated Vercel into our repository so every time a PR against the dev branch is created, the unique preview URLs are being generated now.
cc @addyosmani |
I was responding particularly to this line in your previous comment:
More details here |
I've tried Vercel's Lighthouse and I think we do not have much control over the process. https://vercel.com/nuxt-movies/nuxt-movies/integrations/icfg_nYDnSDMCuBZzqdMbpRsmD5ac |
Could you please set up the repository secrets like so? And also please set up up a GitHub status check by following https://web.dev/lighthouse-ci/#github-status-checks? |
Hey Anton. The above steps should now be completed.
![image](https://user-images.githubusercontent.com/110953/104688105-503a4f00-56b5-11eb-9d82-a31c886f67e5.png)
![image](https://user-images.githubusercontent.com/110953/104688123-56303000-56b5-11eb-8aca-2e63a75b54f8.png)
|
I've got a question about measuring the CLS. I've tried measuring the CLS using Web Vitals Chrome extension. The measured CLS results are quite different. |
One reason this may be is that CLS as implemented in Chrome has received some updates to better account for how developers render modern content in Chrome 88 and 89: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/metrics_changelog/cls.md. |
In this case newer Chrome is always the more reliable (Chrome 90) :) |
It would be helpful to have CWV measurement in place early on in the project so we can see how the metrics trend as optimizations are experimented with.
I believe https://github.com/nuxt-community/web-vitals-module is the current official solution Nuxt.js recommends (need to check if it is baked in now...)
Once we decide where dev/staging should be deployed, I will get GA setup so we have an ID we can use.
The text was updated successfully, but these errors were encountered: