Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when too wide, rows scroll individually #118

Open
djmitche opened this issue Sep 23, 2020 · 4 comments
Open

when too wide, rows scroll individually #118

djmitche opened this issue Sep 23, 2020 · 4 comments

Comments

@djmitche
Copy link
Contributor

After #114 lands, if there's overflow in either the left or right column, then each row scrolls individually.

How could we do better? Can we make the entire column scroll as one?

@djmitche
Copy link
Contributor Author

(See @JiwoonKim's comments in #114 for details)

@helfi92
Copy link
Contributor

helfi92 commented Sep 24, 2020

Making the entire column scroll was the previous implementation. I'm fine with either way. The downside of having the scroller at the bottom is that if the user is viewing a big schema then in order to see the not yet visible section of the panel would involve scrolling to the end of the viewer, moving the scroller, then scrolling back up. This can be annoying for mobile users. From what I can see right now, we decided to pick a better user experience rather than a nicer UI :)

@djmitche
Copy link
Contributor Author

Could we do something with a hover effect and z-order, so that mousing over (or touching) the left side raises the left cell in every row above the right cell?

@helfi92
Copy link
Contributor

helfi92 commented Sep 25, 2020

Absolutely. We could definitely experiment with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants