Skip to content
This repository has been archived by the owner on Nov 12, 2019. It is now read-only.

terminateInstances doesn't handle InvalidInstanceID.NotFound #55

Open
jonasfj opened this issue Feb 3, 2018 · 0 comments
Open

terminateInstances doesn't handle InvalidInstanceID.NotFound #55

jonasfj opened this issue Feb 3, 2018 · 0 comments

Comments

@jonasfj
Copy link

jonasfj commented Feb 3, 2018

See:
https://sentry.prod.mozaws.net/operations/ec2-manager/issues/1353073/

When people sheriffs kill bad instances, and they happen to be gone, they get a 500 error.
If the instanceId doesn't exist, we should probably just return 200 ok... as deleting an instance that doesn't exist seems like a successful noop.

I suspect this can be a race condition where people click multiple times, or the instance is racing to kill itself while people are killing it... Hence, by just saying a missing instance is a successful deletion, we get an idempotent operation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant