You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 12, 2019. It is now read-only.
When people sheriffs kill bad instances, and they happen to be gone, they get a 500 error.
If the instanceId doesn't exist, we should probably just return 200 ok... as deleting an instance that doesn't exist seems like a successful noop.
I suspect this can be a race condition where people click multiple times, or the instance is racing to kill itself while people are killing it... Hence, by just saying a missing instance is a successful deletion, we get an idempotent operation.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
See:
https://sentry.prod.mozaws.net/operations/ec2-manager/issues/1353073/
When people sheriffs kill bad instances, and they happen to be gone, they get a 500 error.
If the instanceId doesn't exist, we should probably just return 200 ok... as deleting an instance that doesn't exist seems like a successful noop.
I suspect this can be a race condition where people click multiple times, or the instance is racing to kill itself while people are killing it... Hence, by just saying a missing instance is a successful deletion, we get an idempotent operation.
The text was updated successfully, but these errors were encountered: