Removing signer from the Action constructor

[marcelomorgado]

A signer shouldn't be mandatory for an action creation. A setter function should be created (Action.setSigner()) instead.

Notes:

• The current Contract code will throw an error if a write function is called without a signer/wallet set. That check should move to the Action.send() function.
• Signer here is the account object created by the tasit-account package.

[pcowgill]

@marcelomorgado Here's what I was trying to convey in the thread that led to this issue. I "misspoke" so it didn't come across clearly.

I think users would probably want to set the signer for the Contract rather than the Action, and then every Action for that Contract would use that signer.

[marcelomorgado]

@marcelomorgado Here's what I was trying to convey in the thread that led to this issue. I "misspoke" so it didn't come across clearly.

I think users would probably want to set the signer for the Contract rather than the Action, and then every Action for that Contract would use that signer.

Ok, I agree. I'm thinking to keep the contract behavior the same as it's today. When a write function will be called the Action object will be instantiated and the signer will be set (the contract's signer).
I've thought to move the signer from the Action constructor to support a use like that:

const rawTx = "...";
const action = new Action(rawTx, provider);
// add signer later
action.setSigner(tasitAccount);
action.send(); // same as signAndSend

Makes sense?

[pcowgill]

Oh okay, so it's already using the contract's signer by default? I see now.

Then yeah, being able to override that with a custom signer is a useful feature - just shoudn't be a mandatory part of the constructor.

If it were an optional part of the constructor with a default rather than using set, that would be fine with me too. No preference.

[pcowgill]

const rawTx = "...";
const action = new Action(rawTx, provider);
// add signer later
action.setSigner(tasitAccount);
action.send(); // same as signAndSend

In this ^ example, when is it signed?

[marcelomorgado]

const rawTx = "...";
const action = new Action(rawTx, provider);
// add signer later
action.setSigner(tasitAccount);
action.send(); // same as signAndSend

In this ^ example, when is it signed?

We have the private signAndSend method, and for now send is an alias for that.

[pcowgill]

We have the private signAndSend method, and for now send is an alias for that.

Ah right. Got it. Thanks!