Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to understand my Github URL #479

Open
Julow opened this issue Jul 18, 2023 · 4 comments
Open

Don't try to understand my Github URL #479

Julow opened this issue Jul 18, 2023 · 4 comments

Comments

@Julow
Copy link
Member

Julow commented Jul 18, 2023

I get this error when I run dune-release opam submit:

dune-release: [ERROR] The URL to your remote fork of opam-repository gh:Julow/opam-repository does not seem to point to a github repo.
  Try editing your config with `dune-release config set remote <URL>` or providing a valid Github repo URL via the --remote-repo option.

No other URL exists due to my configuration. SSH URLs can be arbitrarily complex (even when pointing to Github) and I don't want any tool to decode mines. Git doesn't, for example.

@Leonidas-from-XIV
Copy link
Member

Does the workaround mentioned work though?

The whole opam submit thing is a bit wonky since it uses a local checkout, edits it and submits. In the future I would much prefer to create a commit using the Github API. Then there is no need to deal with peoples URLs and setups.

@Julow
Copy link
Member Author

Julow commented Jul 19, 2023

The problematic part is not requiring a URL, which works fine as long as it doesn't have a meaning other than being a URL for git.
API calls require a user name, and it's currently decoded from the URL of the fork, which makes sense in many cases but doesn't work in general.

I have not found a workaround, this requires a fix: #480

@Julow
Copy link
Member Author

Julow commented Jul 19, 2023

The user name is used to identify branches when creating the PR, something like { "head": "user:branch-name" }.

@Julow
Copy link
Member Author

Julow commented Jan 19, 2024

This is partly fixed by #480 but it's not documented and the tool will not ask for the information interactively (instead it'll fail for a bad reason).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants