Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #98

Merged
merged 8 commits into from
May 8, 2019
Merged

Cleanup #98

merged 8 commits into from
May 8, 2019

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented May 1, 2019

❤ THANKS FOR HELPING OUT :D

Proposed change

  • fixes/updates for examples ( closes Fix examples: bash -> sh #95 )
  • address linter issues
  • remove dead code
  • update deprecated handler for prometheus

Types of changes

What types of changes is this pull request introducing to flottbot? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

You can fill this out after creating your PR. Put an x in the boxes that apply

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@coveralls
Copy link

coveralls commented May 1, 2019

Pull Request Test Coverage Report for Build 203

  • 10 of 74 (13.51%) changed or added relevant lines in 10 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.9%) to 39.561%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/prommetric.go 0 1 0.0%
core/outputs.go 0 3 0.0%
remote/discord/remote.go 0 4 0.0%
remote/slack/util.go 0 8 0.0%
remote/slack/helper.go 0 48 0.0%
Files with Coverage Reduction New Missed Lines %
remote/slack/helper.go 1 0.0%
Totals Coverage Status
Change from base Build 199: 0.9%
Covered Lines: 775
Relevant Lines: 1959

💛 - Coveralls

Copy link
Collaborator

@JordanSussman JordanSussman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor typos

remote/slack/helper.go Outdated Show resolved Hide resolved
remote/slack/helper.go Outdated Show resolved Hide resolved
@JordanSussman
Copy link
Collaborator

LGTM besides a couple of small things.

👏 👏

pa3ng
pa3ng previously approved these changes May 1, 2019
Copy link

@pa3ng pa3ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the above requests, LGTM. Thank you, sir!

@wass3r wass3r merged commit 572e66c into master May 8, 2019
@wass3r wass3r deleted the cleanup branch May 8, 2019 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix examples: bash -> sh
4 participants