Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributeError hides an easy way to break "values" sheet #454

Open
eyeseast opened this issue Dec 13, 2017 · 0 comments
Open

AttributeError hides an easy way to break "values" sheet #454

eyeseast opened this issue Dec 13, 2017 · 0 comments
Labels

Comments

@eyeseast
Copy link
Contributor

Here: https://github.com/tarbell-project/tarbell/blob/master/tarbell/app.py#L526

To reproduce, start a project with a values sheet, but delete the key column header. The project will suddenly have no data, just a sad {}. This is because copy_global_values (https://github.com/tarbell-project/tarbell/blob/master/tarbell/app.py#L537) looks for a key column, can't find it and throws an attribute error. So _get_context_from_gdoc returns an empty dictionary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant