Crashes when supplying an incorrect password.

[tarasis]

Bug report from someone trying to use this project:

The application would
crash if the supplied password is incorrect. The following is the
backtrace:

Program received signal: “EXC_BAD_ACCESS”.
sharedlibrary apply-load-rules all
(gdb) bt
#0 0x00007fff88a49cf1 in flockfile ()
#1 0x00007fff88a52cef in ftello ()
#2 0x000000010000a3ad in File::Tell ()
#3 0x000000010000f069 in Archive::ReadHeader ()
#4 0x0000000100032181 in ProcessFile ()
#5 0x0000000100032286 in RARProcessFile ()
#6 0x00000001000016e2 in -[QuietUnrarAppDelegate extractRarWith:]

(self=0x20005db40, _cmd=0x100002215, filename=0x2000a3900) at
QuietUnrarAppDelegate.m:157
#7 0x000000010000102f in -[QuietUnrarAppDelegate

application:openFiles:] (self=0x20005db40, _cmd=0x7fff875e1336,
theApplication=0x2000150e0, arrayOfFilenames=0x20026e1e0) at
QuietUnrarAppDelegate.m:92
#8 0x00007fff870cd7a2 in -[NSApplication(NSAppleEventHandling)

_handleAEOpenDocumentsForURLs:] ()
#9 0x00007fff86f9a34d in -[NSApplication(NSAppleEventHandling)

_handleCoreEvent:withReplyEvent:] ()
#10 0x00007fff87d0a156 in -[NSAppleEventManager

dispatchRawAppleEvent:withRawReply:handlerRefCon:] ()
#11 0x00007fff87d09f86 in _NSAppleEventManagerGenericHandler ()
#12 0x00007fff83a2d292 in aeDispatchAppleEvent ()
#13 0x00007fff83a2d18b in dispatchEventAndSendReply ()
#14 0x00007fff83a2d095 in aeProcessAppleEvent ()
#15 0x00007fff8245c879 in AEProcessAppleEvent ()
#16 0x00007fff86e9f3d5 in _DPSNextEvent ()
#17 0x00007fff86e9eb41 in -[NSApplication

nextEventMatchingMask:untilDate:inMode:dequeue:] ()
#18 0x00007fff86e64747 in -NSApplication run
#19 0x00007fff86e5d468 in NSApplicationMain ()
#20 0x0000000100000c25 in main (argc=1, argv=0x7fff5fbff7b8) at main.m:13

kill
quit

[tarasis]

I've just been testing locally with both a debug & release build and it doesn't crash for me on either:

1. supplying an incorrect password
2. not supplying a password

The first prints out Error: Process Result was 12 on the console and the second prints out Error: Process Result was 22. As indicated in dll.hpp 12 is ERAR_MISSING_PASSWORD and 22 is ERAR_BAD_DATA.

What character set where you entering the password as? I can see it will crash when I was entering Hebrew or Chinese characters, but the crash trace was quite different from yours:

Program received signal: “EXC_BAD_ACCESS”.
sharedlibrary apply-load-rules all
(gdb) bt
#0 0x00007fff84ba8e00 in strncpy ()
#1 0x0000000100007d4e in strncpyz ()
#2 0x0000000100031e34 in RARSetPassword ()
#3 0x000000010000177e in callbackFunction () at QuietUnrarAppDelegate.m:54
#4 0x000000010001f237 in CmdExtract::ExtractCurrentFile ()
#5 0x0000000100032130 in ProcessFile ()
#6 0x000000010003228a in RARProcessFile ()
#7 0x0000000100001c26 in -QuietUnrarAppDelegate extractRarWith: at QuietUnrarAppDelegate.m:132
#8 0x00000001000018e9 in -QuietUnrarAppDelegate application:openFiles: at QuietUnrarAppDelegate.m:91
#9 0x00007fff80c8c49b in -NSApplication _doOpenFile:ok:tryTemp:
#10 0x00007fff80a74d02 in -NSApplication finishLaunching
#11 0x00007fff80a7460c in -NSApplication run
#12 0x00007fff80a6d468 in NSApplicationMain ()
#13 0x00000001000016f9 in main () at main.m:13

From looking at your stack trace it looks to be crashing processing the headers. What character set are the filenames in? Is the archive small enough that you could send it to me for testing? Or can you make one that exhibits the problem for me.