-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat]: Support for AWS ECR Authentication with Temporary Tokens #13
base: main
Are you sure you want to change the base?
Conversation
83b5ea7
to
d09b5e8
Compare
rewrite the commit msgs
rewrite minor syntax error
rewrite fix build errors due to syntax
Base commit
Update the Example config file
129391b
to
1683cab
Compare
Is this PR fixing your particular issue? |
Yes, the PR adds support for AWS ECR.
As part of this PR, For AWS ECR, this interface is implemented in ecr_credential_helper.go." |
I will review the failed checks and address them. Meanwhile, could you please help review this PR? |
What type of PR is this?
feature
Which issue does this PR fix:
project-zot/zot#2650
What does this PR do / Why do we need it:
This PR adds support for temporary credentials for upstream registries, specifically focusing on AWS ECR. Since ECR credentials are not permanent and need to be rotated periodically, this enhancement enables Zot to dynamically obtain and refresh valid usernames and passwords when the CredentialHelper is configured for the registry
If an issue # is not available please add repro steps and logs showing the issue:
N/A
Testing done on this change:
During initialization, the logs confirm that ECR credentials have been updated:
During credential expiry, the following log entries are generated:
These logs verify that the credentials are nearing the expiry window of one hour and have been successfully refreshed.
Automation added to e2e:
Added TestECRCredentialsHelper in sync_internal_test
Will this break upgrades or downgrades?
No
Does this PR introduce any user-facing change?:
No
release-note
With this PR, users can configure AWS ECR as an upstream registry for on-demand or periodic sync by setting
CredentialHelper: ecr
in the extension sync configuration. This change eliminates the need for users to manually add usernames and passwords in thecredentialsFile
; instead, credentials will be stored in memory and automatically rotated as they approach expiry. An example configuration is available inexamples/config-sync-ecr-credential-helper.json
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.