You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the current implementation of the nREPL support (ClojureNReplMojoj.java), I noticed that an edge case is missing. User in the list below refers to user of clojure-maven-plugin.
User doesn't specify custom handler nor custom middleware -> no problem, nREPL defaults end up being used
User specifies custom nREPL handler and no custom nREPL middleware -> no problem, user-specified nREPL handler gets merged with nREPL default middleware
User specifies custom nREPL middleware and no custom nREPL handler -> no problem, user-specified nREPL middleware gets merged with nREPL default handler
User specifies both custom nREPL handler and custom nREPL middleware -> this is a problem, only the custom nREPL handler is being merged, custom nREPL middleware is ignored.
This is not a use case that comes up frequently, and it's possible to work around it, but it might be a good idea to handle it anyway.
The text was updated successfully, but these errors were encountered:
Or, instead of handling the case, throw an error to indicate that either a custom nREPL handler can be used, or user-supplied middleware, but not both at the same time.
In the current implementation of the nREPL support (
ClojureNReplMojoj.java
), I noticed that an edge case is missing. User in the list below refers to user ofclojure-maven-plugin
.This is not a use case that comes up frequently, and it's possible to work around it, but it might be a good idea to handle it anyway.
The text was updated successfully, but these errors were encountered: