Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App. H: Tokens $7A and $7B Missing #73

Open
7 tasks
tajmone opened this issue Mar 10, 2020 · 1 comment
Open
7 tasks

App. H: Tokens $7A and $7B Missing #73

tajmone opened this issue Mar 10, 2020 · 1 comment
Labels
📚 CHANGELOG Documenting changes between releases 💡 new contents Additional book contents proposal (text and/or code) 📋 Roody Notes From @roodyyogurt annotated PDF of Hugo Book 🕑 pending decision Issue requires decisions by maintainers 💀 missing contents Some text or code is missing. 💀 text problems Text problems, typos or obsolete contents. ⚠️ important Priority: High
Milestone

Comments

@tajmone
Copy link
Owner

tajmone commented Mar 10, 2020

NOTE 1 — These changes were originally part of Issue #65, and then moved here to create an independent Issue (see NOTE 2 below).


  • Get @tessman approval for these changes.
  • In Appendix H: Code Patterns, add missing tokens:
    • $7A addcontext
    • $7B video
  • Document their addition in:
    • CHANGES.md.
    • README.md » Changelog.

In his annotated PDF, @roodyyogurt pointed out that two tokens are missing in Appendix H: Code Patterns.

Although this would imply adding new contents to the book, it might be justified since App. H is supposed to list all Hugo tokens, and therefore fall within the goals of the original book.

But, of course, this needs to be discussed and evaluated first.

If we decide no to add the missing tokens, we could then at least add an admonition mentioning the problem.

NOTE 2 — There were other tokens-related problems, pointed out by Roody, which were addressed and fixed in #65. The reason these specific changes were moved to a separate Issue is because they imply adding new contents — which might be beyond the current goals of this project, so it might be better to handle them separately from the other fixes.

@tajmone tajmone added ⚠️ important Priority: High 🕑 pending decision Issue requires decisions by maintainers 💀 text problems Text problems, typos or obsolete contents. 📋 Roody Notes From @roodyyogurt annotated PDF of Hugo Book 📚 CHANGELOG Documenting changes between releases labels Mar 10, 2020
@tajmone tajmone added this to the text fixes milestone Mar 10, 2020
@tajmone tajmone added the 💀 missing contents Some text or code is missing. label Mar 10, 2020
@tajmone
Copy link
Owner Author

tajmone commented Mar 10, 2020

See also what was already discussed on these addition, in #65:

@tajmone tajmone added the 💡 new contents Additional book contents proposal (text and/or code) label Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 CHANGELOG Documenting changes between releases 💡 new contents Additional book contents proposal (text and/or code) 📋 Roody Notes From @roodyyogurt annotated PDF of Hugo Book 🕑 pending decision Issue requires decisions by maintainers 💀 missing contents Some text or code is missing. 💀 text problems Text problems, typos or obsolete contents. ⚠️ important Priority: High
Projects
None yet
Development

No branches or pull requests

1 participant