Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some ECO symbols were duplicated in the gene annotation method field #321

Open
JKingSE opened this issue Jan 15, 2019 · 3 comments
Open
Assignees
Labels

Comments

@JKingSE
Copy link
Contributor

JKingSE commented Jan 15, 2019

Overview: This was specifically seen with ECO:0000316, genetic interaction evidence used in manual assertion. This duplication also seemed to be connected with the Evidence With field not appearing for IGI or IPI synonyms (this may be an front-end issue with the old react front-end, may not apply to the refactored front end)

Full discussion notes from meeting: When choosing method as double mutant phenotypic evidence used in manual assertion, multiple duplicates came up.
When IGI or IPI in methods are the types of methods, evidence is required to be put in (see issues). It seems like something is wrong with mapping ECO (ECO:0000316) terms to evidence codes. Upon further testing, it seems that the Evidence With field does appear for some methods with the synonyms IGI or IPI. The evidence should be the codes for genes, and there should be a button for optional further evidences. (Its possible the Evidence With box didn’t come up because the repeating entries, which shouldn’t exist, just choose the first one which isn’t marked as a synonym)

@lreiser
Copy link

lreiser commented Jan 15, 2019

Related issues from last year
#239
#220
#195

There is a subset of ECO terms that have a corresponding association to the three letter codes.
they are in a file located here
http://purl.obolibrary.org/obo/eco/gaf-eco-mapping-derived.txt
Although we import all of ECO we only want to display the subset of terms.

We actually do two types of filtering for ECO terms

  1. Display only ECO terms that map to 3 letter code
  2. For certain TYPES of annotations- we also filter the available list of ECO terms, again based on Evidence Code. So for example, choosing protein- protein interaction as an annotation type means that the ONLY ECO terms that should be available in the methods are those that map back to the IPI (Inferred from Physical Interaction) three letter code.

@tberardini
Copy link

I still see duplicates:

image

@qwertyflagstop
Copy link
Contributor

To fix this, analogous entries need to be pruned. Moving to to-do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants